Skip to content

Conversation

@schilling40
Copy link
Contributor

Parallelization of the prediction and segmentation using the distance U-Net.
Includes scripts for resizing wrongly scaled cochleas and converting tif to n5.
WIP

Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this looks good! The only major comment is that I don't see where you start the slurm array job in case of prediction_instances > 1.

Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just a few cosmetic changes. The test error should be resolved when the new torch_em release is pulled (will be on conda-forge soon, see conda-forge/torch_em-feedstock#20 )

Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, and the test passes. I will go ahead and merge it.

@constantinpape constantinpape merged commit f12f9d3 into master Apr 9, 2025
6 checks passed
@constantinpape constantinpape deleted the parallelize_prediction branch April 9, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants